EACH_DICT_ENTRY_ON_SEPARATE_LINE for OrderedDict?

[concretevitamin]

Here's a diff before and after yapf with google style:

-all_processes = OrderedDict([(PROCESS_TYPE_MONITOR, []),
-                             (PROCESS_TYPE_LOG_MONITOR, []),
-                             (PROCESS_TYPE_WORKER, []),
-                             (PROCESS_TYPE_LOCAL_SCHEDULER, []),
-                             (PROCESS_TYPE_PLASMA_MANAGER, []),
-                             (PROCESS_TYPE_PLASMA_STORE, []),
-                             (PROCESS_TYPE_GLOBAL_SCHEDULER, []),
-                             (PROCESS_TYPE_REDIS_SERVER, []),
-                             (PROCESS_TYPE_WEB_UI, [])],)
+all_processes = OrderedDict(
+    [(PROCESS_TYPE_MONITOR, []), (PROCESS_TYPE_LOG_MONITOR, []),
+     (PROCESS_TYPE_WORKER, []), (PROCESS_TYPE_LOCAL_SCHEDULER,
+                                 []), (PROCESS_TYPE_PLASMA_MANAGER, []),
+     (PROCESS_TYPE_PLASMA_STORE, []), (PROCESS_TYPE_GLOBAL_SCHEDULER,
+                                       []), (PROCESS_TYPE_REDIS_SERVER,
+                                             []), (PROCESS_TYPE_WEB_UI, [])], )

I think we can agree the before version is more readable ;) I can think of several possibilities:

• Is there a EACH_DICT_ENTRY_ON_SEPARATE_LINE counterpart for OrderedDict?
  • Or each list entry on separate line?
• As a workaround I currently just disable yapf for this statement.

[flunderpero]

Another workaround would be to enable the knob split_arguments_when_comma_terminated=True (which imho is a good idea anyway) and add a , after the last element of the array. Each element will then be put on a separate line.

[concretevitamin]

That works! I will leave this open in case the maintainers decide a direct solution is desirable.

[bwendling]

What @flunderpero suggested is the recommended way of "fixing" this. There might be a better heuristic we can apply here, but it will take a bit of thinking...