search

google / yggdrasil-decision-forests

A library to train, evaluate, interpret, and productionize decision forest models such as Random Forest and Gradient Boosted Decision Trees.
https://ydf.readthedocs.io/
Apache License 2.0
473 stars 49 forks source link

Documentation for using Go is out of date #52

Closed jimidle closed 1 year ago

jimidle commented 1 year ago

The documentation indicates to use an import starting with "google3/...." but this needs to be:


import (
    modelio "github.com/google/yggdrasil-decision-forests/yggdrasil_decision_forests/port/go/model/io/canonical"
    "github.com/google/yggdrasil-decision-forests/yggdrasil_decision_forests/port/go/serving"
)

Also the README and the current docs show using model_io as an import alias, but it is not idiomatic to use _ in variables or aliess etc.

rstz commented 1 year ago

Hi, thank you for reporting this, I'll go over the Go documentation and fix this issue