google / zetasql

ZetaSQL - Analyzer Framework for SQL
Apache License 2.0
2.28k stars 214 forks source link

Upgrade ICU to remove icu `-Wimplicit-int-to-float-conversion` warning. #122

Open markww opened 1 year ago

markww commented 1 year ago

In the version of ICU used by ZetaSQL at HEAD at the time of this writing, in icu/source/i18n/plurrule.cpp, there is an implicit conversion from int to float here: https://github.com/unicode-org/icu/blob/fd123bf023882f07bfacf51c39111be2f946d8f8/icu4c/source/i18n/plurrule.cpp#L1664 . This forces me to turn off the -Wimplicit-int-to-float-conversion warning in my project when attempting to use ZetaSQL, which is unfortunate as it is a high-value warning. I noticed that in the most recent release of ICU, this has been fixed with a static_cast. Would it be possible to address this issue by upgrading ZetaSQL to the most recent ICU?