search

google / zoekt

Fast trigram based code search
1.67k stars 113 forks source link

Use template files instead of strings #102

Closed axispx closed 4 years ago

axispx commented 4 years ago

zoekt uses in-memory template strings instead of separate files which makes it difficult to add features to the web interface. Moving these strings to the files should be the way forward to make development of the web interface easier.

axispx commented 4 years ago

I see that there is an option to dump the template but I'm not really sure why it was the design decision. Can somebody clear it up for me?

I wanted to add some GUI filters and I removed the template strings and added template files but I don't know if the project wants go in that direction.

filters

hanwen commented 4 years ago

there already is an option, see here https://github.com/google/zoekt/blob/b1730d8e0cc4aa35d6b2d593b83fef7cb0c81673/cmd/zoekt-webserver/main.go#L118