google / zoekt

Fast trigram based code search
1.7k stars 113 forks source link

Support ** for LargeFiles patterns. #135

Closed rmmh closed 3 years ago

rmmh commented 3 years ago

This is done by simply changing from filepath.Match to doublestar.PathMatch. A few minor tests are included.

The only syntax change is that now matches any number of directories, so "/*.lock" will match a file with a "lock" extension anywhere in the path. Since "**" had no special meaning before, this change should not cause any surprising changes.

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

rmmh commented 3 years ago

@googlebot I fixed it.

hanwen commented 3 years ago

can you send a review through Gerrit as documented in CONTRIBUTING ?

rmmh commented 3 years ago

done. https://gerrit-review.googlesource.com/c/zoekt/+/308802