google / zoekt

Fast trigram based code search
1.69k stars 113 forks source link

Add files without text to index? #57

Closed TobiX closed 6 years ago

TobiX commented 6 years ago

When a file isn't added to the index because it's not text, you cannot even find its file name. Would it be possible/desirable to at least add the file to the index as an "empty" file (maybe setting the language to "binary")?

Bonus points if the user can even see why the file was excluded. Hound does this:

grafik

I'm willing to implement this myself, just wanted to ask if this is something that sounds useful.

hanwen commented 6 years ago

yes. Good idea.

A quick solution is to just replace the body with the reason. More advanced would be to add a new field (which would require an index version bump.)

heltonmarx commented 6 years ago

Hi @hanwen

I'm working on this task and I submitted it to Gerrit (here). If you have any comments or suggestions please feel free to let me know.