Added ContinueOnError flag

r10r commented 5 years ago

Implements #73 .

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

r10r commented 5 years ago

I signed it!

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

r10r commented 5 years ago

I've added my work email to github email settings.

googlebot commented 5 years ago

CLAs look good, thanks!

hanwen commented 5 years ago

can you follow instructions in CONTRIBUTING ?

I usually do code reviews in Gerrit.

thanks!

r10r commented 5 years ago

done!

Currently tests for the change are missing - I can add them, but this will take some time.

Btw. one test is already failing in master (without my contribution):

root@shieldos-dev:~/gopath/src/github.com/google/zoekt/build# go test -v .
[...]
=== RUN   TestPartialSuccess
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00000.zoekt: 3299 index bytes (overhead 2.9)
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00001.zoekt: 3300 index bytes (overhead 2.9)
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00002.zoekt: 3300 index bytes (overhead 2.9)
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00003.zoekt: 3300 index bytes (overhead 2.9)
--- FAIL: TestPartialSuccess (0.01s)
    e2e_test.go:296: got shards [/tmp/480465520/repo_v15.00000.zoekt /tmp/480465520/repo_v15.00001.zoekt /tmp/480465520/repo_v15.00002.zoekt /tmp/480465520/repo_v15.00003.zoekt], want []

google / zoekt