Add missing installing instruction for automaxprocs

ngirard commented 5 years ago

Following the instructions led to

go install github.com/google/zoekt/cmd/zoekt-index
/home/ngirard/go/src/github.com/google/zoekt/cmd/zoekt-index/main.go:30:2: cannot find package "go.uber.org/automaxprocs/maxprocs" in any of:
        /usr/lib/go-1.10/src/go.uber.org/automaxprocs/maxprocs (from $GOROOT)
        /home/ngirard/go/src/go.uber.org/automaxprocs/maxprocs (from $GOPATH)

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

ngirard commented 5 years ago

@googlebot I signed it!

Le ven. 2 août 2019 à 23:44, googlebot notifications@github.com a écrit :

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version https://opensource.google.com/docs/cla/#troubleshoot).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.

The email used to register you as an authorized contributor must also be attached to your GitHub account https://github.com/settings/emails.

ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fzoekt%2Fpull%2F96 for more info.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/zoekt/pull/96?email_source=notifications&email_token=AAAX6MR5KSN4GH63EMHZYYTQCSTDFA5CNFSM4IJBHOM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3O46KI#issuecomment-517852969, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAX6MU7WRUVQEXTAUCI3STQCSTDFANCNFSM4IJBHOMQ .

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

hanwen commented 5 years ago

which Go version are you using? The module spec should have handled this for you.

hanwen commented 5 years ago

please use the procedure mentioned in CONTRIBUTING for sending me code.

thanks,

ngirard commented 5 years ago

which Go version are you using? The module spec should have handled this for you.

I did sudo apt install golang-go on Ubuntu 19.04, which brought golang-1.10-go 1.10.4-2ubuntu1

amacfie commented 4 years ago

@ngirard try running go get github.com/google/zoekt/... first

google / zoekt