googleads / google-ads-dotnet

This project hosts the .NET client library for the Google Ads API.
https://developers.google.com/google-ads/api
Apache License 2.0
73 stars 97 forks source link

Error NU1202 Package Google.Ads.GoogleAds 19.0.1 is not compatible with net8.0 (.NETCoreApp,Version=v8.0) #559

Closed AnthonyGiretti closed 7 months ago

AnthonyGiretti commented 7 months ago

Hi , I'm working with .NET 8. Unfortunately versions >= 18.1.0 (same for 19.0.1) of the Nuget package does not support .NET 8 while 17.1.0 DOES and I need to move on V16 GoogleAds. The sunset of V14 is in May. V15 is not worth it; its sunset is in September 2024.

Subsequent to the following ticket: Will you allow .NET 8 soon? It's blocking us.

image

image

Raibaz commented 7 months ago

Hi, I can't seem to be able to reproduce this issue; in fact, I have been testing the library myself with .NET 8.0 and we have evidence of it being used with .NET 8.0, so I'd need some more details to understand where the issue lies.

Would you be able to put together a small repo I cant take a look at to reproduce the issue?

AnthonyGiretti commented 7 months ago

Hi,

Thanks for your reply, I have been able to isolate a project in a repo here: https://github.com/AnthonyGiretti/Test-Google-Api

When I try to compile it I get this: image

I flushed my Nuget cache and the same is still happening:

image

Raibaz commented 7 months ago

I cloned the repo, but I'm getting several compilation errors as it appears to be missing some required dependencies:

[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Repositories/IAdsRepository.cs(1,26): error CS0234: The type or namespace name 'Domain' does not exist in the namespace 'Integration.Shared' (are you missing an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Repositories/AdsRepository.cs(2,26): error CS0234: The type or namespace name 'Domain' does not exist in the namespace 'Integration.Shared' (are you missing an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/AdsService.cs(1,26): error CS0234: The type or namespace name 'Domain' does not exist in the namespace 'Integration.Shared' (are you missing an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedAdsService.cs(1,26): error CS0234: The type or namespace name 'Domain' does not exist in the namespace 'Integration.Shared' (are you missing an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedCustomerManagerService.cs(1,26): error CS0234: The type or namespace name 'Domain' does not exist in the namespace 'Integration.Shared' (are you missing an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedCustomersService.cs(1,26): error CS0234: The type or namespace name 'Domain' does not exist in the namespace 'Integration.Shared' (are you missing an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/IAdsService.cs(1,26): error CS0234: The type or namespace name 'Domain' does not exist in the namespace 'Integration.Shared' (are you missing an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/UploadCallConversionService.cs(1,7): error CS0246: The type or namespace name 'AzureIntegrationServices' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/UploadClickConversionService.cs(1,7): error CS0246: The type or namespace name 'AzureIntegrationServices' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedAdsService.cs(8,22): error CS0246: The type or namespace name 'ICacheService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Repositories/IAdsRepository.cs(9,15): error CS0246: The type or namespace name 'AdWordsClickPerformanceReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/AdsService.cs(33,28): error CS0246: The type or namespace name 'AdWordsClickPerformanceReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedAdsService.cs(11,29): error CS0246: The type or namespace name 'ICacheService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/AdsService.cs(46,28): error CS0246: The type or namespace name 'AdWordsCallMetricsReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Repositories/IAdsRepository.cs(10,15): error CS0246: The type or namespace name 'AdWordsCallMetricsReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedCustomerManagerService.cs(8,22): error CS0246: The type or namespace name 'ICacheService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedCustomerManagerService.cs(10,89): error CS0246: The type or namespace name 'ICacheService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedCustomersService.cs(8,22): error CS0246: The type or namespace name 'ICacheService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/IAdsService.cs(8,15): error CS0246: The type or namespace name 'AdWordsClickPerformanceReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/Caching/CachedCustomersService.cs(10,71): error CS0246: The type or namespace name 'ICacheService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/IAdsService.cs(9,15): error CS0246: The type or namespace name 'AdWordsCallMetricsReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/UploadClickConversionService.cs(10,22): error CS0246: The type or namespace name 'ISerializationService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/UploadClickConversionService.cs(14,41): error CS0246: The type or namespace name 'ISerializationService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/UploadCallConversionService.cs(10,22): error CS0246: The type or namespace name 'ISerializationService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Services/UploadCallConversionService.cs(14,40): error CS0246: The type or namespace name 'ISerializationService' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Repositories/AdsRepository.cs(55,28): error CS0246: The type or namespace name 'AdWordsClickPerformanceReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]
[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Repositories/AdsRepository.cs(108,28): error CS0246: The type or namespace name 'AdWordsCallMetricsReportModel' could not be found (are you missing a using directive or an assembly reference?) [[PATH REDACTED]/Test-Google-Api/Integration.Shared.Google/Integration.Shared.Google.csproj]

No errors about the compatibility of the package Google.Ads.GoogleAds or its dependencies with net8.0 though.

AnthonyGiretti commented 7 months ago

Don't pay attention to missing dependencies. I have flushed twice my Nuget cache and now it's working.... Thank you....