search

googleads / google-ads-php

Google Ads API Client Library for PHP
https://developers.google.com/google-ads/api/docs/client-libs/php
Apache License 2.0
280 stars 260 forks source link

The SuggestionDataOneof class doesn't exsist when upgrading from V15 to V16 #1023

Closed yj-pqp closed 3 months ago

yj-pqp commented 3 months ago

This class is missing Google\Ads\GoogleAds\V16\Services\SuggestSmartCampaignBudgetOptionsRequest\SuggestionDataOneof

It's even used in a code example: https://github.com/googleads/google-ads-php/blob/main/examples/AdvancedOperations/AddSmartCampaign.php#L74

Is it deprecated or something? How should i fix this issue?

I'm gonna revert the changes and wait for a solution before upgrading to the next version

Any help would be greatly appreciated

fiboknacky commented 3 months ago

That should be the leftover from the last GAPIC version. I'm sorry for this confusion, but we should be able to remove that import without affecting the code.

yj-pqp commented 3 months ago

Ok i see, thanks for your response

1024 closes this issue