pySilver
commented
3 years ago Ok, I've managed to create sitelinks in batch job by NOT setting resource_name on extension_feed_item_operation but rather using Temporary ID for .id property of operation like this:
[extension_feed_item_operation {
create {
sitelink_feed_item {
link_text: "Buty zimowe"
final_urls: "https://domain.com/buty-zimowe-damskie/2a/"
}
extension_type: SITELINK
id: -10
targeted_ad_group: "customers/<hidden>/adGroups/-3"
}
},
ad_group_extension_setting_operation {
create {
extension_type: SITELINK
ad_group: "customers/<hidden>/adGroups/-3"
extension_feed_items: "customers/<hidden>/extensionFeedItems/-10"
}
},
extension_feed_item_operation {
create {
sitelink_feed_item {
link_text: "Buty zimowe"
final_urls: "https://domain.com/buty-zimowe-damskie/2a__zapiecie-buta-zamek/"
}
extension_type: SITELINK
id: -18
targeted_ad_group: "customers/<hidden>/adGroups/-11"
}
},
ad_group_extension_setting_operation {
create {
extension_type: SITELINK
ad_group: "customers/<hidden>/adGroups/-11"
extension_feed_items: "customers/<hidden>/extensionFeedItems/-18"
}
},
extension_feed_item_operation {
create {
sitelink_feed_item {
link_text: "Kozaki damskie"
final_urls: "https://domain.com/kozaki-damskie/2a/"
}
extension_type: SITELINK
id: -26
targeted_ad_group: "customers/<hidden>/adGroups/-19"
}
},
ad_group_extension_setting_operation {
create {
extension_type: SITELINK
ad_group: "customers/<hidden>/adGroups/-19"
extension_feed_items: "customers/<hidden>/extensionFeedItems/-26"
}
},
extension_feed_item_operation {
create {
sitelink_feed_item {
link_text: "Kozaki damskie"
final_urls: "https://domain.com/kozaki-damskie/2a__zapiecie-buta-zamek/"
}
extension_type: SITELINK
id: -34
targeted_ad_group: "customers/<hidden>/adGroups/-27"
}
},
ad_group_extension_setting_operation {
create {
extension_type: SITELINK
ad_group: "customers/<hidden>/adGroups/-27"
extension_feed_items: "customers/<hidden>/extensionFeedItems/-34"
}
}]However when reading errors I'm still seeing this error:
Batch job #51 has a status "Multiple errors in ‘details’. First error: Field must be set., at mutate_operations[51].ad_group_extension_setting_operation" and response type "N/A"
#....
Out[26]:
operation_index: 51
status {
code: 3
message: "Multiple errors in \342\200\230details\342\200\231. First error: Field must be set., at mutate_operations[51].ad_group_extension_setting_operation"
details {
type_url: "type.googleapis.com/google.ads.googleads.v6.errors.GoogleAdsFailure"
value: "\n^\n\003\270\006$\022\022Field must be set.\032\002*\000\"?\022\025\n\021mutate_operations\0303\022&\n$ad_group_extension_setting_operation"
}
}What field I'm not setting? I'm setting all required fields from https://developers.google.com/google-ads/api/reference/rpc/v6/AdGroupExtensionSetting?hl=en like this:
def _build_ad_group_extension_settings_operation(
self, ad_group_resource_name: str, feed_item_resource_names: List[str]
) -> AdGroupExtensionSettingOperation:
"""
Builds Ad Group extension setting operation
:param ad_group_resource_name: Ad Group resource name
:return: AdGroupExtensionSettingOperation
"""
ad_group_ext_setting_operation = self.client.get_type(
"AdGroupExtensionSettingOperation", version=GOOGLE_ADS_API_VERSION
)
extension_type_enum = self.client.get_type("ExtensionTypeEnum", version=GOOGLE_ADS_API_VERSION)
ad_group_ext_setting = ad_group_ext_setting_operation.create
ad_group_ext_setting.resource_name = ad_group_resource_name
ad_group_ext_setting.ad_group = ad_group_resource_name
ad_group_ext_setting.extension_type = extension_type_enum.SITELINK
ad_group_ext_setting.extension_feed_items.extend(feed_item_resource_names)
return ad_group_ext_setting_operation
BBalazsJurgen
BenRKarl
UPDATE: Partially solved. Please see following comment.
Hi! Is that possible to create sitelinks and assign them into ad group in the same Batch Job?
I have a method that creates a sitelink extension like this:
So I'm creating few sitelinks using
_build_ad_group_sitelink_extension_operationmethod and then I'm trying to assign them into ad group usingFeed item resource names looks the following:
and then I'm creating
AdGroupExtensionSettingOperationfinally I'm appending my
ExtensionFeedItemOperations andAdGroupExtensionSettingOperationto a batch job;The response from batch job contains the following error:
So it looks like I cannot use temporary IDs for feed items? What should I do differently to create feed items and assign into ad group in a single Batch Job then?