googleads / google-ads-ruby

Google Ads API Ruby Client Library
https://developers.google.com/google-ads/api/
Apache License 2.0
71 stars 65 forks source link

`page_size` param deprecated for V16 #496

Open kaushik-rg opened 3 months ago

kaushik-rg commented 3 months ago

What is your question?

https://ads-developers.googleblog.com/2024/07/upcoming-changes-to-page-size-in-google.html is page_size param skipped from the api request if we don't pass it while requesting

service.search(customer_id: xxxx, query: query)

we are using v28.0.0 of this package and V16 Google Ads api Version.

mcloonan commented 3 months ago

After the changes, the page size will be defaulted to 10,000. If you specify a page size other than 10,000, the request will fail with an error. If you specify a page size of exactly 10,000, I'm not sure what will happen to be honest, but it's probably best to just avoid sending that parameter from now on.

AnashOommen commented 3 months ago

You will get an error even when setting page size to 10000. So don't set it at all; the field will go away sometime in the future.

On Wed, Jul 31, 2024, 8:29 AM mcloonan @.***> wrote:

After the changes, the page size will be defaulted to 10,000. If you specify a page size other than 10,000, the request will fail with an error. If you specify a page size of exactly 10,000, I'm not sure what will happen to be honest, but it's probably best to just avoid sending that parameter from now on.

— Reply to this email directly, view it on GitHub https://github.com/googleads/google-ads-ruby/issues/496#issuecomment-2260409520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCOJCCYNNY4UEKXR2XCL23ZPDKDHAVCNFSM6AAAAABLXZZVDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRQGQYDSNJSGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>