search

googleads / google-api-ads-ruby

Ad Manager SOAP API Client Libraries for Ruby
297 stars 227 forks source link

Fix build for ads_common and migrate to minitest #102

Closed seuros closed 8 years ago

seuros commented 8 years ago

Test/unit is deprecated, replaced with minitest Removed monkey patching to String

We should remove httpclient as dependency as we are using HTTPI

mcloonan commented 8 years ago

Hello,

If you want to make pull requests, please limit them in scope to very specific issues. I can't accept this because it makes tons of style changes throughout the code base which I don't have any interest in switching to.

A single pull request that fixes the build and nothing more, a separate one to switch to minitest and nothing more, and I might be able to consider it. (Although I would have to talk to my team about the minitest one.)

Also, httpclient is mandatory for the batch_job_utils in the adwords_api. HTTPI is just an interface layer; the underlying library is also important.