search

googleads / google-api-ads-ruby

Ad Manager SOAP API Client Libraries for Ruby
297 stars 227 forks source link

Support rails 3 #132

Closed robinbortlik closed 7 years ago

robinbortlik commented 7 years ago

Hello guys,

first, thank you very much for your gem which saves us a lot of work.

We are using yours adwords-api gem in our Rails 3 monolith application and actually we are not able to update adwords-api gem to latest version due to conflict in dependency libraries. As latest action_pack version (3.22.5) depends on Builder ~> 3.0.0 (https://rubygems.org/gems/actionpack/versions/3.2.22.5) and yours google-ads-savon depends on Builder ~> 3.2. (https://github.com/googleads/google-api-ads-ruby/commit/adcac47c7b9d52e14bf345494a8799644c67863f )

Solution seems to be quite easy. Just changing Builder dependency to ~> 3.0. This will allow owners of Rails 3 applications to install this gem without problem.

Adding screenshot where is should be clearly visible. builder

Thank you very much for considering this change.

dklimkin commented 7 years ago

Hello Robin,

Thank you for reporting this issue. I'll review if we can relax the dependency requirement here.

robinbortlik commented 7 years ago

Thank you very much @dklimkin :)

dklimkin commented 7 years ago

Fixed in ec3902c5ca03c9334903d4ba8b3901585d4f2d4b

robinbortlik commented 7 years ago

Thank you very much for fix @dklimkin

m1k3 commented 7 years ago

Can you also release this to rubygems?

dklimkin commented 7 years ago

Good point, we've missed to release ads-savon with the 1.0.0 release. Should be out soon.

mcloonan commented 7 years ago

Sorry about that, ads-savon 1.0.3 gems are published now.