googleads / google-api-ads-ruby

Ad Manager SOAP API Client Libraries for Ruby
297 stars 229 forks source link

2.4.0 uses v202305 API version of Google Ad Manager, not v202308 #194

Closed taras-sarmat closed 10 months ago

taras-sarmat commented 1 year ago

Hi everyone!

I want to update my project to use the latest version of GAM API: v202308

I updated the gem to the latest version: gem 'google-dfp-api', '=2.4.0'-> but it seems that it still uses previous version v202305.

Some testing locally:

gem 'google-dfp-api', '=2.4.0'
...
api_client.version
=> :v202305

gem 'google-dfp-api', '=2.3.0' 
...
api_client.version
=> :v202305

gem 'google-dfp-api', '=2.2.0' 
...
api_client.version
=> :v202302

Should we wait for a fix?

taras-sarmat commented 1 year ago

@christopherseeley Could you check please this issue? Thanks!

christopherseeley commented 1 year ago

Thanks for pointing this out. v202308 is available, just not the default. I'll send out a fix.

In the meantime, you can specify it when creating the service:

order_service = ad_manager.service(:OrderService, :v202308)
taras-sarmat commented 1 year ago

@christopherseeley thanks a lot!

taras-sarmat commented 10 months ago

Resolved https://github.com/googleads/google-api-ads-ruby/commit/1778b315349f210c8cabe9d57c5e430081e7c5a3#diff-935902af6cc6c6efab4a9acccfba44b928c81e2570a90eb753181d7d962c215fR7