Set nokogiri dependency to 1.6 for google-ads-common

googleads / google-api-ads-ruby

Ad Manager SOAP API Client Libraries for Ruby

297 stars 227 forks source link

Set nokogiri dependency to 1.6 for google-ads-common #195

Closed mherasymiv-blackbird closed 5 months ago

mherasymiv-blackbird commented 8 months ago

Upgrade fails because of dependency on nokogiri version (1.12.5)

Follow up from comment

We should not depend on such an old nokogiri version. Also it has to be consistent with version used in ads-savon.

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

dawidof commented 5 months ago

Could anybody merge with PR? As this gem is not working with latest rails

christopherseeley commented 5 months ago

Thanks for pointing this out. Fixed in 2.0.1