search

googleads / google-api-ads-ruby

Ad Manager SOAP API Client Libraries for Ruby
297 stars 227 forks source link

Remove upper dependency for faraday #196

Closed kmymtksh closed 2 months ago

kmymtksh commented 7 months ago

Faraday is used to pass to Signet::OAuth2::Client instance. https://github.com/googleads/google-api-ads-ruby/blob/main/ads_common/lib/ads_common/auth/oauth2_handler.rb#L104

Signet does not depend Faraday 1.x, so we can remove the upper dependency in this gem. https://github.com/googleapis/signet/blob/main/signet.gemspec#L23

dawidof commented 3 months ago

Is it going to be merged?

christopherseeley commented 2 months ago

Our library still supports 2.7, faraday removed support in for it in 2.9. Would capping at < 2.9 be sufficient for your use case?

kmymtksh commented 2 months ago

@christopherseeley Thank you for your response! It makes sense, added in https://github.com/googleads/google-api-ads-ruby/pull/196/commits/119638787a1f75fade01a9ca18d4f500fc783d20