googleads / googleads-consent-sdk-android

Consent SDK
https://developers.google.com/admob/android/eu-consent
Apache License 2.0
100 stars 82 forks source link

Add .gitignore and switch to AndroidX #105

Open ufoq opened 4 years ago

ufoq commented 4 years ago

Most of users use this lib together with ads libs that already use AndroidX and it may be troublesome to keep old appcompat working with AndroidX, that's why it's better to just switch to it.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

ufoq commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ufoq commented 4 years ago

BTW it's weird to have dependency on appcompat just for annotations, maybe switching 'implementation' to 'testImplementation' is enough (this way there will be no dependency problems no matter what lib dev will use). I can make PR if you want.