Open ufoq opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
BTW it's weird to have dependency on appcompat just for annotations, maybe switching 'implementation' to 'testImplementation' is enough (this way there will be no dependency problems no matter what lib dev will use). I can make PR if you want.
Most of users use this lib together with ads libs that already use AndroidX and it may be troublesome to keep old appcompat working with AndroidX, that's why it's better to just switch to it.