googleads / googleads-consent-sdk-android

Consent SDK
https://developers.google.com/admob/android/eu-consent
Apache License 2.0
100 stars 82 forks source link

Add localized strings to the Google-rendered consent form #107

Open xanewton opened 4 years ago

xanewton commented 4 years ago

The library works fine. However, the Google-rendered consent form only displays text in English. If the device language is set in any other language, the text in the dialog only appears in English (see image).

android_eu_consent_form

Please implement the text as localizable strings (at least in the languages used in Europe) instead of using hardcoded strings inside the html in googleads-consent-sdk-android/consent-library/src/main/assets/consentform.html

Screen Shot 2020-04-22 at 2 45 55 PM

Error observed in Library version: com.google.android.ads.consent:consent-library:1.0.8 for Android

Steps-To-Duplicate:

  1. Implement the library as described in AdMob documentation https://developers.google.com/admob/android/eu-consent
  2. Show the Google-rendered consent form in the Emulator and change the device language to any other European Language besides English. For example, French.
  3. Observe the unlocalized text in the dialog. (see images for an example) Screenshot_1587581549 Screenshot_1587581641 Screenshot_1587581650
flatslats commented 4 years ago

+1

RoqueCampos commented 4 years ago

+1