search

googleads / googleads-consent-sdk-android

Consent SDK
https://developers.google.com/admob/android/eu-consent
Apache License 2.0
100 stars 74 forks source link

App requires permission WRITE_EXTERNAL_STORAGE needed #26

Closed cyberdreamandroid closed 6 years ago

cyberdreamandroid commented 6 years ago

When I build my apps using the consent-library 1.0.1 my AndroidManifest is extended by READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE. If I remove the dependency, no permission is added. This is reproducable. Didn't somebody test this?

Also it is not possible to localize the text. This library is a ridicolous. It is not compliant with GDPR/DSGVO to show a german user an english data policy. You could at least add the possibility by overriding text files in localized raw folders or anything else. When did Google start to develop this library, last week? It was released 5 days before GDPR/DSGVO comes into effect. So many hard working developers who need to build it by themselves now :(

frankyxcs commented 6 years ago

you can change everything you want ! Just include only the library folder by yourself into android studio

include ':consent-library'

implementation project(':consent-library')

sync it and you have full control over the code !

cyberdreamandroid commented 6 years ago

Of course. But this is not how it is intended. I built a much better solution now in a few hours. Shame on Google for not supporting their developers like they should.

frankyxcs commented 6 years ago

yes 100 % bad for a billion dollar company :( :( :(:

i have made my own version to of this library with more languages because time hurries

rampara commented 6 years ago

@frankyxcs @cyberdreamandroid this permission will be removed in an upcoming release of this SDK. Closing as duplicate of #13.