search

googleads / googleads-consent-sdk-android

Consent SDK
https://developers.google.com/admob/android/eu-consent
Apache License 2.0
100 stars 82 forks source link

Added ConsentStatus.AD_FREE_PREFERRED #34

Open DesigningKnights opened 6 years ago

DesigningKnights commented 6 years ago

When getting consent, the return of ConsentStatus.UNKNOWN for the user preferring an ad-free version is confusing, as it also is the return for the consent being unknown. In addition, having UNKNOWN returned when retrieving the status when the user prefers an ad-free version is also a confusing issue. Granted, if an app is using an in-app purchase to remove ads, then the consent status dialog should not come up, but it would be nice to have that status available if the user has reinstalled, or installed on another device.

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

DesigningKnights commented 6 years ago

My unused github account was attached to this for some reason as a participant. I've removed it.

ufoq commented 4 years ago

IANAL, but it may be problematic to store user preference (that he prefers ads), that's why it's just set to unknown for everything that does not imply consent.