googleads / googleads-consent-sdk-android

Consent SDK
https://developers.google.com/admob/android/eu-consent
Apache License 2.0
100 stars 82 forks source link

Allow users to display the consent form outside of the EEA #83

Open shortercode opened 6 years ago

shortercode commented 6 years ago

I've written a wrapper for this SDK and the admob SDK to allow users of our game engine to display ads. Some of our users have expressed the want to display the consent form outside of the EEA as well.

I have implemented the checks within the wrapper to decide if it should be shown using the requestConsentInfoUpdate and isRequestLocationInEeaOrUnknown methods as indicated in the documentation. However, when trying to display the form using DEBUG_GEOGRAPHY_NOT_EEA location the form returns the following error Error: request is not in EEA or unknown..

Producing the error is understandable, but it makes it impossible to choose to display the form anyway. In addition the documentation and the API itself suggest the developer is making the decision about showing the form, but the only choice they are seemingly given is to not show it.

The safety provided by the error could remain if this was implemented as a method on ConsentInformation like so:

ConsentInformation.getInstance(context).showOutsideOfEea(true);