search

googleads / googleads-consent-sdk-android

Consent SDK
https://developers.google.com/admob/android/eu-consent
Apache License 2.0
100 stars 82 forks source link

Added translations #86

Closed santimar closed 1 year ago

santimar commented 5 years ago

Since this library should be used in EU, I added translation for

Translation were provided by @codenia at https://github.com/googleads/googleads-consent-sdk-android/issues/14#issuecomment-396576726 I dropped Chinese, Japanese, Korean, Russian since they are not EU countries. This should close #14

Johnson145 commented 5 years ago

Unfortunately, the translated form files aren't up-to-date anymore. So I can use the English version without a custom provider selection, but it won't work using the other languages. This is because the latest template changes have not yet been applied to the translations.

Update: I've just updated the translated files and created a pull request on your repo. If anybody else is interested in the changes, you can get them from this branch of my fork.

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

santimar commented 5 years ago

@Johnson145 I added your changes to this PR. If it ever gets approved...

Johnson145 commented 5 years ago

Thanks!

I confirm that I'm ok with my commits being contributed to this project.

I don't think this PR will get approved, as it's still a workaround only. In the meantime, it's been really helpful to me though and I'm sure it will be to more people.

codenia commented 5 years ago

I also confirm that I'm ok with my translations being contributed to this project.

stowy commented 5 years ago

Just an update that we are aware that this project is not getting the attention it deserves, and we're planning to address that this quarter, hopefully this month. We appreciate your pull requests and encourage you to keep contributing. Be prepared for review in coming weeks, in the meantime please ensure you have signed the CLA and that the CLA check has passed.

googlebot commented 5 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

wharnisch commented 4 years ago

When will we see a new version of the googleads-consent-sdk containing this very important fix ???

marco97pa commented 4 years ago

When will we see a new version of the googleads-consent-sdk containing this very important fix ???

April 2020 and still we haven't got a localized Consent Library