googleads / googleads-consent-sdk-ios

Consent SDK
https://developers.google.com/admob/ios/eu-consent
Apache License 2.0
31 stars 47 forks source link

Fix issue with parsing JSON response in incorrect CP1251 encoding #14

Open accidbright opened 6 years ago

accidbright commented 6 years ago

Issue: https://github.com/googleads/googleads-consent-sdk-ios/issues/13

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
accidbright commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

Izzyjm commented 5 years ago

when will this be merged ? @googlebot why are there alot of issues you guys reviewed but have not merged ?