search

googleads / googleads-dotnet-lib

Google Ad Manager SOAP API .NET client library
Apache License 2.0
109 stars 199 forks source link

Library doesn't read EndTime in extensions #242

Closed AlesSturala closed 2 years ago

AlesSturala commented 2 years ago

Hello,

I believe that the library doesn't parse EndTime correctly from the SOAP request. I perform the following AdWords API call on /api/adwords/cm/v201809/CustomerExtensionSettingService through the .NET library:

SELECT Extensions LIMIT 0, 1000

I have a promotion extension with end date set but when returned through the query above the extension has ((ExtensionFeedItem)extension).endTime=NULL.

In the SOAP message I can see the EndTime to have the correct value:

20211225 000000 null

Request ID: 0005d2bbe97e723000008b78490ab74d

Privately I can share the complete detailed log of the request.

PS: I also think that the Placeholder Feed Item report has the same issue, I can see that the saved XML also has endDate saved as '--when querying for the same extension through the Reporting API.

AlesSturala commented 2 years ago

Update: I found out that promotion extensions have 2x end dates - one coming from the generic Placeholder Feed Item model and next to that, Promotion Extension has its own start and end dates. For promotion therefore it is needed to read the promotion dates. I'm closing this issue.