search

googleads / googleads-mobile-ios-mediation

Apache License 2.0
120 stars 137 forks source link

chagne version number + add constraints #339

Closed Oravraham5 closed 3 years ago

Oravraham5 commented 3 years ago

Hey @chlandacastro i did not understand your last comments, can you clarify what you need me to do?

chlandacastro commented 3 years ago

HI @Oravraham5 I was asking if you can add a comment about the added constraints on the code. And could you also removed the brackets around the version number, like so #### Version 8.0.0.0. Thanks.

Oravraham5 commented 3 years ago

@chlandacastro Done.

chlandacastro commented 3 years ago

@Oravraham5 Sorry for the misunderstanding but the brackets should have been removed for the #### Version 8.0.0.0 only , not the others. The brackets are part of the link to its corresponding Zip URL, if removed, the other version won't have a link. to the zip URL like so, https://developers.google.com/admob/ios/mediation/fyber#fyber-ios-mediation-adapter-changelog. Only the version in progress doesn't have brackets since its corresponding Zip URL doesn't exist yet.

Oravraham5 commented 3 years ago

@chlandacastro np, fixed it