search

googleads / googleads-mobile-ios-mediation

Apache License 2.0
120 stars 137 forks source link

Update Unity AdMob Adapter for 4.0.0 release #342

Closed vita-unity closed 2 years ago

vita-unity commented 2 years ago

Description

This PR updates our adapter to use our new 4.0.0 SDK and includes refactoring and improvements.

How

Update Unity dependencies to 4.0.0. Removed enablePerPlacementLoad flag from initialize call and any other references to classes removed in 4.0.0. Refactor GADMAdNetworkAdapter and GADMediationAdapter to use proxy classes for UnityAds delegate. Fix crash related to placementInUse map. Small code improvements like comment updates and function restructuring.

Test

I tested the adapter still works using our test app to load/show banners, interstitial and rewarded ads and ensuring all the events are properly sent

NOTE - Unity Ads 4.0 is not out yet, but wanted to start the review process so that the adapter can be updated shortly after our release

vita-unity commented 2 years ago

I've signed the CLA, could you please re-run the check?

chlandacastro commented 2 years ago

Hi, vita-unity, the CLA still needs to be signed.
Regards, Christian.

chlandacastro commented 2 years ago

HI @vita-unity the CLA is still missed.

vita-unity commented 2 years ago

HI @vita-unity the CLA is still missed.

Hi @chlandacastro, I'm checking the cla page and I have the signed agreement Screen Shot 2021-12-01 at 8 32 30 AM Do I need to sign something else?

chlandacastro commented 2 years ago

hi @vita-unity. It is still showing that the CLA is missing. You need to be part of the Google Group tied to Unity's Corporate CLA google-contributors@unity3d.com. Could you check with Stephanie, from Unity, about this missing CLA. Regards, Christian.

vita-unity commented 2 years ago

@chlandacastro Thank you for your review! I've changed year back to 2020 for the old files and renamed categories files. Please let me know if you have any other comments.

chlandacastro commented 2 years ago

@vita-unity Hi Vita! can you to sync this PR with the latest changes. This PR is already merged but it is not closed yet. We want to confirm the PR with the latest changes. Thanks.

vita-unity commented 2 years ago

@chlandacastro looks like latest commit didn't come through. Could you please make sure it's merged since it's fixing a build error in the previous commit?