googleads / googleads-mobile-ios-mediation

Apache License 2.0
120 stars 137 forks source link

IronSource New Adapter #418

Closed alon357 closed 1 year ago

alon357 commented 1 year ago

Refactor for the iOS adapter. The ideas behind the refactoring are very similar and the overall adapter architecture is as follows:

We have created new classes for each ad format:

Each class contains the ad format-specific functionality. Each of the above classes contains a static instance of either

These handle the SDK callbacks for the respective ad format. We have removed the ISMediationManager class and split its functionality between the different ad format classes.

Consecutively we have removed the GADMAdapterIronSourceRewardedDelegate and GADMAdapterIronSourceInterstitialDelegate protocols.

The refactor of course also includes the addition of the banner ad unit. Thank.

joshh-devrel commented 1 year ago

@alon357 Can you resolve the conflicts in your branch? Thanks!

joshh-devrel commented 1 year ago

@alon357 @Ophir-IS Can you resolve the conflicts in your branch and rebase the PR? Thanks!

joshuajplagonera commented 1 year ago

We are having issues with building the adapter's framework for an "iOS device" and we are getting an unsupported Swift architecture error coming from the IronSource-Swift.h header file. image

Are there additional steps needed aside from the ones outlined in your integration guide? https://developers.is.com/ironsource-mobile/ios/ios-sdk/#step-1

alon357 commented 1 year ago

Hi @joshh-devrel We have fixed the build issue.