search

googleads / googleads-mobile-ios-mediation

Apache License 2.0
119 stars 137 forks source link

Problems with the versions in the Info.plist files #448

Open stsandro opened 6 months ago

stsandro commented 6 months ago

There are some restrictions around what a proper version looks like. I get the following error when building my app for release on Xcode Cloud:

ITMS-90060: This bundle is invalid - The value for key CFBundleShortVersionString '12.2.1.0' in the Info.plist file at 'Payload/MyCool.app/Frameworks/AppLovinAdapter.framework' must be a period-separated list of at most three non-negative integers. Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring

There is also another problem regarding the minimum supported version:

ITMS-90208: Invalid Bundle - The bundle MyCool.app/Frameworks/AppLovinAdapter.framework does not support the minimum OS Version specified in the Info.plist.

This error is also emitted from other frameworks like GoogleMobileAds

As far as I can tell this problem only occurs with Xcode 15.3

Palbrevik commented 3 months ago

Similar issue, but within MetaAdapter.frameWork: "key CFBundleShortVersionString '6.15.0.0' in the Info.plist file at 'Payload/Tradera.app/Frameworks/MetaAdapter.framework' must be a period-separated list of at most three non-negative integers. Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring".

This problem occurs in Xcode 15.3 and Xcode 15.4, but not on Xcode 15.0.

Seems like a pretty easy fix. Pls raise priority on this, since it is blocking us from upgrading 🙏 😏.

SzGajdzica commented 2 months ago

Now GoogleMobileAds requires xcode 15.3 and this dependency blocks it. Please post a fix on that!

rursache commented 2 months ago

you can edit the info.plist inside the framework file and change the CFBundleShortVersionString to 6.15.0 until google get their 💩 together. same for the other mediators if needed

s2mr commented 2 months ago

The workaround above does not seem to work with Xcode15.4. In Xcode15.4, the Code sign check fails if there are changes to files in the framework.

This also occurs when uploading to the store as well as XcodeCloud.

/projects/Pods/MyFramework.xcframework:1:1: error: The signature of MyFramework.xcframework” cannot be verified.
    note: A sealed resource is missing or invalid
    note: /projects/Pods/MyFramework.xcframework: a sealed resource is missing or invalid
file modified: /projects/Pods/MyFramework.xcframework/ios-arm64_x86_64-simulator/MyFramework.framework/Info.plist
file modified: /projects/Pods/MyFramework.xcframework/ios-arm64/MyFramework.framework/Info.plist

Hopefully Google will respond soon!