googleads / googleads-mobile-unity

Official Unity Plugin for the Google Mobile Ads SDK
https://developers.google.com/admob/unity
Apache License 2.0
1.36k stars 1.08k forks source link

Google Mobile Ads SDK with Swift Package Manager (SPM)? #1125

Closed stiliyanv closed 1 year ago

stiliyanv commented 4 years ago

Is there a way to import Google Mobile Ads SDK into my Xcode application through Swift Package Manager (SPM) instead of CocoaPods or Manual Download?

This repository doesn't have Package.swift file so I suppose that it is not designed to work with SPM. Any future plans in this direction?

stowy commented 4 years ago

No, sorry there are not currently any plans to support SPM, it does not contain any swift code.

la-pieuvre commented 3 years ago

Now that SPM supports xcframework to deliver binary code, will GAM sdk provides a SPM version?

adiracu commented 3 years ago

Have a look at how Firebase made it work with SPM via binary xcframeworks.

Both Firebase & GoogleMobileAds are ObjC only frameworks and share similar dependencies (GoogleAppMeasurement, FBLPromises, nanopb, GoogleUtilities), so I assume it's possible to also make GoogleMobileAds SPM compatible.

At the moment, GoogleMobileAds is our only non SPM dependency, forcing us to keep using CocoaPods. It would be nice to leave CocoaPods behind and have a clean Xcode project for once :) .

carloshwa commented 3 years ago

@stowy I don't think issue should be closed. It is necessary and possible (see Firebase).

stowy commented 3 years ago

Hi @carloshwa - you are correct, we are reviewing this at the moment.

PahlevanyanSamvel commented 3 years ago

@stowy I really need to use GoogleSignIn and GoogleMobileAds with swift package manager , please help me.

zaniluca commented 3 years ago

Any update?

maddevrelgithubbot commented 3 years ago

Hello, we're actively working on this however we are looking into ways to depend on GoogleAppMeasurement since it's not currently support SPM. We're talking to them about this.

FranFus commented 3 years ago

Any news about SPM support?

pddkhanh commented 3 years ago

I see XCFramework of Google is now available to download. Does anyone know how to declare Package.swift locally to use those frameworks in form of SPM?

mezhevikin commented 3 years ago

@maddevrelgithubbot Hi! GoogleAppMeasurement supports SPM now. Any update?

https://github.com/google/GoogleAppMeasurement/blob/main/Package.swift

dankinsoid commented 3 years ago

Hi! Any updates?

FranFus commented 3 years ago

It would be great to have at least some news and feedbacks from contributors

FranFus commented 3 years ago

Still nothing official?

vince1393 commented 3 years ago

Any update on this?

aliosmanuysal commented 3 years ago

I've just seen your email, I'll try and let you know

29 Nis 2021 Per 02:51 tarihinde Vincent Romani @.***> şunu yazdı:

Any update on this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/googleads/googleads-mobile-unity/issues/1125#issuecomment-828852175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJJ5QMS7H4UGILDBRGSNHLTLCNRPANCNFSM4KCD6HLQ .

quanghits commented 3 years ago

I have update SPM for Admob 8.4.0. You can download it on link https://github.com/quanghits/GoogleMobileAds

quanghits commented 3 years ago

I updated SPM for Admob 8.5.0. https://github.com/quanghits/GoogleMobileAds

vince1393 commented 3 years ago

Any update on getting this package working on SPM? If not we're going to just remove it during our next refactor. Google libraries are starting to create too much overhead nowadays

houmie commented 3 years ago

Any news about SPM support, please?

quanghits commented 3 years ago

Any news about SPM support, please?

Download on my repository, I update each new version.

https://github.com/quanghits/GoogleMobileAds

nathanfallet commented 3 years ago

Thanks for you work @quanghits, you saved many of us. But why is Google not doing it? They did it for Firebase, why not AdMob...

ericleich commented 3 years ago

Swift package manager support is on the roadmap. Should be rolled this quarter, targeting August. It will NOT be in this repo though, because this repo is not the iOS SDK. Since the Google Mobile Ads SDK for iOS is not open source, there will be a separate repo for it, similar to how https://github.com/quanghits/GoogleMobileAds is set up.

Having said that, please help me understand why SPM affects you on Unity. The plugin uses https://github.com/googlesamples/unity-jar-resolver which leverages CocoaPods to pull in the iOS libraries. How will you take advantage of SPM for your Unity projects? Are all of these upvotes really from users that are stripping out that way of pulling in libraries, and setting up your own dependencies through SPM?

inc-ali commented 3 years ago

Any news on this? Since there is isn't any repo yet, will the announcement be made in this issue?

jkozlowicz commented 3 years ago

@ericleich is there already another repo with AdMob for SPM? You mentioned August and the end of August is approaching, but I still cannot find it.

Many thanks for looking into this!

rafagan commented 2 years ago

Any news?

twhitt14 commented 2 years ago

Any updates? It's past August...

zaniluca commented 2 years ago

Some news about the integration anyone?

simspace-dr commented 2 years ago

@ericleich any word on Google Ads Swift package manager support yet?

sean7512 commented 2 years ago

Any updates here? This is badly needed

Polenoso commented 2 years ago

@sean7512 I use this package and it's working so far.

https://github.com/Koze/GoogleMobileAds-SPM

JMCPH commented 2 years ago

What's the status of this ticket?

Climbatize commented 2 years ago

@Polenoso https://github.com/Koze/GoogleMobileAds-SPM seems similar to this one

https://github.com/quanghits/GoogleMobileAds

which one is the legit one?

Polenoso commented 2 years ago

@Polenoso https://github.com/Koze/GoogleMobileAds-SPM seems similar to this one

https://github.com/quanghits/GoogleMobileAds

which one is the legit one?

I don't know. I have published one App using the one from Koze, but it seems they're following similar approaches.

Climbatize commented 2 years ago

I don't know. I have published one App using the one from Koze, but it seems they're following similar approaches.

Seems one is a rip-off of the other one. It should have been a fork and credit the original author. I went with Koze's repo too, as it supports one version earlier than Quanguits'

ZeeWanderer commented 2 years ago

Seems one is a rip-off of the other one. It should have been a fork and credit the original author. I went with Koze's repo too, as it supports one version earlier than Quanguits'

It can't be a fork because there is nothing to fork. iOS sdk for AdMob is not public. Those repos contain binaries + SPM files. I think people ask about SPM here because there is no iOS repo except examples and this issue on Unity SDK actually gained traction so when you search for AdMob SPM support you get here and see an active issue.

ZeeWanderer commented 2 years ago

I suppose making your own SPM repo for iOS SDK is rather easy but you would need to maintain it yourself. But that is true for CocoaPods too, you can easily make your own pod spec and then add your private spec repo. Being able to easily setup SPM package is not a reason to not have an official SPM package. Other deps, including those made by google already have one, why not iOS AdMob sdk?

quanghits commented 2 years ago

@Polenoso https://github.com/Koze/GoogleMobileAds-SPM seems similar to this one

https://github.com/quanghits/GoogleMobileAds

which one is the legit one?

As ericleich, both in the same way to set up to make an SPM. Library extracted from Google Admob SDK.

I created this repo because Koze's version stopped updating after a long time. I want to provide users with a regularly updated repo.

Never mind which version is first. Please choose the better version. If you can make a better version, just clone and benefit the community.

shahla00 commented 2 years ago

Still no update from Google?

ekucet commented 2 years ago

okay, I'm going to use cocoapod in my project for just admob!

nomi1315 commented 2 years ago

Still waiting :(

jdurieu commented 2 years ago

The sdk is now available as Swift Package => https://github.com/googleads/swift-package-manager-google-mobile-ads

ericleich commented 2 years ago

Sorry for lack of updates from contributors on this. As the community has noticed already at this point, per above comments, the Google Mobile Ads iOS SDK now has an official swift package manager repo.

That said, does this address the problem for Unity developers? The plug-in’s dependency setup leverages External Dependency Manager (EDM), whose iOS dependencies are done through CocoaPods. Unless you decide to strip out EDM and manage your drops manually through SPM, I’m not sure how the SPM release of the Google Mobile Ads SDK helps you.