googleads / googleads-mobile-unity

Official Unity Plugin for the Google Mobile Ads SDK
https://developers.google.com/admob/unity
Apache License 2.0
1.34k stars 1.08k forks source link

Unity Package Manager (UPM) support #1416

Closed ErnSur closed 2 months ago

ErnSur commented 3 years ago

[REQUIRED] Step 1: Describe your environment

[REQUIRED] Step 2: Describe the problem

This plugin is missing unity's package manager support. Many Unity packages from Google follow the UPM package standard. UPM standard requires things like:

This would be a great QoL improvement for developers.

Steps to reproduce:

Relevant Code:

robinryf commented 3 years ago

This would really help with keeping everything up-to-date having multiple projects

stowy commented 3 years ago

We agree and are working on making this happen. It will be released following a refactor of the native ads plugin and should go out in the next month or so.

ErnSur commented 3 years ago

Any news on that?

Zamaroht commented 3 years ago

Any ETA on this?

scriptsengineer commented 3 years ago

Update? do it , this high need feature.

stowy commented 3 years ago

It will be done prior to the end of the year.

On Tue, Nov 17, 2020 at 9:45 PM Rafael Correa notifications@github.com wrote:

Update? do it , this high need feature.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/googleads/googleads-mobile-unity/issues/1416#issuecomment-728873977, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNGOFFVA4J3H6G64A66ODTSQJO4HANCNFSM4P5EE4SQ .

kerembaydogan commented 3 years ago

@stowy it is almost the end of the year.

just saying :)

lwthorns commented 3 years ago

@stowy Would you please update eta for this? My team needs to make decisions for our project based on this issue.

Thaina commented 3 years ago

It will be done prior to the end of the year. On Tue, Nov 17, 2020 at 9:45 PM Rafael Correa @.***> wrote: Update? do it , this high need feature. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1416 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNGOFFVA4J3H6G64A66ODTSQJO4HANCNFSM4P5EE4SQ .

End of which year?

Also there is https://github.com/googleads/googleads-mobile-unity/blob/master/ChangeLog.txt about UPM in 6.0.0 but I don't see there are 6.0.0 yet, am I missing something?

thsbrown commented 3 years ago

Would also love to check in on the status of this 👍 .

Zamaroht commented 3 years ago

I'm also interested in this issue, would be really helpful for integrations

robinryf commented 3 years ago

This issue is probably too much to wish for since Google is not continuing to provide Unity Package Manager support for other Google packages: https://github.com/firebase/quickstart-unity/issues/1028

It would still be very great to add the AdMob integration to https://developers.google.com/unity/archive so it can be included in our own Unity registries and resolve dependencies correctly when the External Dependency Manager is already included in the project.

sirgatsen commented 1 year ago

Has this trail gone cold? Anyone to update us with an alternative way apart from .unitypackage?

NVentimiglia commented 1 year ago

Hi Everyone, thanks for the feedback. I will look into this functionality.

NVentimiglia commented 1 year ago

Hi Everyone, UMP is now live in 7.4.0.

sirgatsen commented 1 year ago

Many many thanks my friend, I can't wait to test it out!

Oh man, I almost got excited. We need Unity Package Manager (UPM) and not User Messaging Platform (UMP)

Thaina commented 1 year ago

Wait... Is it UPM or UMP ?

robinryf commented 1 year ago

I think there has been a misunderstanding here @NVentimiglia

This issue asks for Unity Package Manager (UPM) support. It seems version 7.4.0 added support for User Messaging Platform (UMP).

While I do like the addition of UMP, this is not what this issue is about. Could you please re-open the issue?

Thaina commented 1 year ago

@NVentimiglia You have closed the wrong issue

ErnSur commented 1 year ago

I updated the issue so this it is more clear and more relevant, as it was created in 2020. As others have said, it was closed for the wrong reason. @NVentimiglia

Thaina commented 1 year ago

@NVentimiglia One month had passed for closing the wrong issue

ChanUkLee commented 1 year ago

@NVentimiglia The issue needs to be reopened

Thaina commented 1 year ago

I just thought I would ping this again at the end of this month

NVentimiglia commented 1 year ago

@Thaina

Thank you. We are still looking into this feature.

Xeoneid commented 10 months ago

any news on this? It would be an appreciated QoL update

NVentimiglia commented 10 months ago

We are looking into UPM support. I will update this thread when I can give a specific date.

LitQoo commented 9 months ago

@NVentimiglia I am using Admob sdk personally made for unity package manager. com.google.external-dependency-manager can be shared with firebase, so I created a separate repository. The same goes for mediation like AppLovin. Please note. It wasn't too difficult to make. With this, I can update the admob of more than 5 projects at once, which is very convenient.

https://github.com/LitQoo/com.google.ads.mobile https://github.com/LitQoo/com.google.external-dependency-manager https://github.com/LitQoo/com.google.ads.mobile.adapter.applovin

NVentimiglia commented 9 months ago

Thats great @LitQoo

Agree UPM is a value add and official support still scheduled to be added.

FemLolStudio commented 5 months ago

Any update about it?

NVentimiglia commented 5 months ago

@FemLolStudio

Still a work in progress. We are aiming for early Q1.

NVentimiglia commented 2 months ago

Closing this issue here. Last time I spoke I said early Q1, but we are still aiming for a Q1 release.

Thaina commented 2 months ago

Should we have this closed after it actually released?

ErnSur commented 2 months ago

I also don't like the act of closing an issue before the changes are actually released. We heard about this feature coming in 2020

NVentimiglia commented 1 month ago

https://developers.google.com/admob/unity/quick-start#import_the_mobile_ads_for_unity_plugin