search

googleads / googleads-php-lib

Google Ad Manager SOAP API Client Library for PHP
Apache License 2.0
656 stars 769 forks source link

Symfony serializer dependency conflict #739

Closed xaben closed 1 year ago

xaben commented 2 years ago

Would it be possible to add the latest version of the "symfony/serializer" to the allowed list of versions?

"symfony/serializer": "^3.0.3 || ^4.4.0 || ^5.0.0" to "symfony/serializer": "^3.0.3 || ^4.4.0 || ^5.0.0 || ^6.0.0"

Thank you for your support and time.

PierrickVoulet commented 2 years ago

Hi @xaben - The version 5.4 is LTS (supported until 2024), just curious, could you elaborate why you need the support of 6.0?

xaben commented 2 years ago

Hi @PierrickVoulet - Thanks for looking into this.

I'm trying to upgrade a Laravel project, which uses laravel-doctrine as a dependency. I've opened a corresponding issue there as well, as only symfony/serializer^6.0 is allowed on the latest version.

Just looking forward to fixing it from either side. Thank you!

PierrickVoulet commented 2 years ago

Thanks for the additional context, @xaben. I gave it a try but this would not be a trivial change for our library (I got errors when doing so). Knowing that the version 5.4 is LTS until 2024, let's wait for laravel-doctrine's answer. Also, could you tell me if you are using our library to connect to the AdWords API or the Ad Manager API?

xaben commented 2 years ago

Thanks again, we can wait for laravel-doctrine's answer, my impression was that 6.0 is same is same as 5.4 without the deprecated things, could be wrong.

We are connecting to the AdManager API, running some reports, importing some KPIs.

Alex-DA commented 2 years ago

Hello, we want to upgrade a big project to PHP 8.1 and Symfony 6.1 but is not possible because the same issue. We can help somehow to resolve the conflict in googleads-php-lib? Regards.

ghnp5 commented 1 year ago

Having a similar issue here.

I can't upgrade symfony/mailer to 6.2.5, because googleads-php-lib depends on symfony/serializer to be on v5

PierrickVoulet commented 1 year ago

This is fixed in v60.