search

googleads / googleads-php-lib

Google Ad Manager SOAP API Client Library for PHP
Apache License 2.0
656 stars 769 forks source link

[PHP8.1] PHP Deprecated: Return type of Google\AdsApi\Common\AdsSoapClient::__doRequest #742

Closed mrceperka closed 2 years ago

mrceperka commented 2 years ago

Hello,

I've recently came across this error:

PHP Deprecated:
Return type of Google\AdsApi\Common\AdsSoapClient::__doRequest($request, $location, $action, $version, $one_way = 0)
should either be compatible with
SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string,
or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Could this be fixed in a future version? Or can I fix this on my end somehow?

Thanks.

PierrickVoulet commented 2 years ago

Hi @mrceperka - This seems to be a duplicate of #733, could you confirm?

mrceperka commented 2 years ago

@PierrickVoulet yes, looks like it.

PierrickVoulet commented 2 years ago

Closing this issue then, let's follow up on the original one.