googleads / googleads-python-lib

The Python client library for Google's Ads APIs
Apache License 2.0
681 stars 974 forks source link

Remove unused dependency: xmltodict #524

Open gdrosos opened 1 year ago

gdrosos commented 1 year ago

Summary

Hello @christopherseeley, @msaniscalchi,

I hope you're doing well! I've just opened this pull request that proposes the removal of the unused dependency xmltodict from the setup.py configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The xmltodict package was added in e8dea47, and was used in googleads/adwords.py. However, this file was later removed, and upon analysis of the codebase, it was found that it is not currently being utilized within the project. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

Impact

I have also signed a individual CLA, according to CONTRIBUTING.md