googleads / googleads-python-lib

The Python client library for Google's Ads APIs
Apache License 2.0
683 stars 975 forks source link

Enable constructing GoogleServiceAccountClient with Credentials.from_service_account_info method #532

Open attilatoth86 opened 1 year ago

attilatoth86 commented 1 year ago

When initializing a GoogleServiceAccountClient, it expects Service Account JSON key file but there is no way to pass in the key file content as dictionary (e.g. after reading out from a secret store) because the constructor is limited to use the google.oauth2.service_account.Credentials.from_service_account_file()class method. Can this constructor be extended with .from_service_account_info() method, too?

https://google-auth.readthedocs.io/en/master/reference/google.oauth2.service_account.html#google.oauth2.service_account.Credentials.from_service_account_info

christopherseeley commented 7 months ago

Thanks for the suggestion! In the meantime, you can use any google.oauth2 Credentials object with this library https://github.com/googleads/googleads-python-lib/blob/main/googleads/oauth2.py#L215