search

googleads / publisher-ads-lighthouse-plugin

Publisher Ads Audits for Lighthouse is a tool to improve ad speed and overall quality through a series of automated audits. This tool will aid in resolving discovered problems, providing a tool to be used to evaluate effectiveness of iterative changes while suggesting actionable feedback.
https://developers.google.com/publisher-ads-audits
Apache License 2.0
98 stars 45 forks source link

update to lighthouse 10.1.1 #395

Open connorjclark opened 1 year ago

connorjclark commented 1 year ago

Smokes seem to be failing on main already, FYI.

jburger424 commented 1 year ago

Sorry for missing this earlier. Looks like there are some new failures though?

connorjclark commented 1 year ago

Yeah, I spent the last hour updating everything. Removed the fake-types and using the real types we started publishing, which uncovered a lot of issues I believe I've fixed now.

I'm unsure about this runWarning I get in the smokes though. "The GPT tag was not requested." on every run ... is isImplTag still up-to-date in terms of the URL assets it checks?

brendankenny commented 1 year ago

@connorjclark is it also possible to update the ProcessedNavigation.request() calls to pass in the trace directly so we can update that in LH too?

https://github.com/GoogleChrome/lighthouse/blob/b36b21334b835acc7a991852614e08964cb1c063/core/computed/processed-navigation.js#L26

(we probably should have left the types stricter like PageDependencyGraph did so it would have been an error when you switched to the real types)

connorjclark commented 1 year ago

I went back to to 1.5.0 of this plugin (which uses LH 8) and that also results in The GPT tag was not requested.. I don't see any requests matching what lighthouse-plugin-publisher-ads/utils/resource-classification.js is checking for. @jburger424 have the GPT scripts changed recently?