googleads / swift-package-manager-google-interactive-media-ads-tvos

Apache License 2.0
2 stars 7 forks source link

IMA iOS SDK and IMA tvOS SDK cannot be used together #1

Open abdullahsoylemez opened 8 months ago

abdullahsoylemez commented 8 months ago

I'm working on a project that has both iOS and tvOS targets. After installing IMA iOS SDK for iOS target via SPM, when I want to install IMA tvOS SDK for tvOS target, I get an error like this:

multiple products named 'GoogleinteractiveMediaAds' in: 'swift-package-manager-google-interactive-media-ads-ios, 'swift-package-manager-google-interactive-media-ads-tvos'

yusufcancakmak commented 8 months ago

+1

abdullahknz commented 8 months ago

+1

OsmanBesli commented 8 months ago

+1

smaljaar commented 7 months ago

Seeing this issue too. I could resolve it temporarily by manually downloading and installing the tvOS SDK as described in https://developers.google.com/interactive-media-ads/docs/sdks/tvos/client-side#manually_downloading_and_installing_the_sdk

mark-gage commented 6 months ago

+1

Looks like the package names need to be different between iOS and tvOS

RTodorov commented 6 months ago

@gschoppe is there any solution for this problem? perhaps adding a suffix to one of the libraries would solve the issue?

jromanos-hiberus commented 5 months ago

@gschoppe is there any solution for this problem? perhaps adding a suffix to one of the libraries would solve the issue?

I think the only solution right know is to fork one of the packages and changing the name of the package for disambiguation. Although, this solution is not the best one for a long life application; as updates may be done by hand.

You can have a look at my fork for reference: https://github.com/jromanos-hiberus/swift-package-manager-google-interactive-media-ads-tvos

sheiladoherty-dolby commented 4 months ago

+1

sheiladoherty-dolby commented 4 months ago

I created a PR for this change, so you can also tie directly into that commit: 59189ffae1c43461c8b75262fecef87aed4bba2f

gschoppe commented 2 months ago

Hang in there, folks. We are currently weighing the impact of a couple of different solutions to this issue on our engineering end, and should have a definitive solution soon.

~Greg