search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

Full-slot non-linear ads serving from vmaps breaks the player #1017

Closed komw closed 2 years ago

komw commented 2 years ago

There is a bug in handling the full-slots non-linear ads inside the vmap files. When there is a full-slot non-linear ad before the linear ad in the same adbreak, after skipping, or playing the full-slot non-linear ad any videojs-ima player hangs up.

Example: Please use below vmap file: (there is no difference between breakType linear/nonlinear in the first ad)

`

` and the simplified version of full-slot non-linear vast file: _full-slot-nonlinear.xml_ ` AdSense ` Please use samples from above with players directly from https://github.com/googleads/videojs-ima/tree/master/examples -> the player will hangs and stops playing ad/content after playing/skipping the first ad from above vmap file. It seems that videojs-ima are not triggering the 'ad end' event in such case, and it stays in 'ad playing' state without changing the current ad to the next one. The ad controls and whole ad overlay stays on the screen( the non-linear ad dissapear) and user cannot do anything because of that strange player state.
Kiro705 commented 2 years ago

Hello @komw ,

I am having trouble reproducing the behavior you are seeing. Would it be possible to share the exact VAST that causes the error?

I played both VASTs you provided and saw ad playback followed by video playback.

komw commented 2 years ago

@Kiro705 its not a separate config,so do not play it separately, but the first file is the Vmap which should use a second VAST tag.

I created a ready VMAP file for you: https://cdn.veedmo.com/cdn/samples/ads/player-dev-ads/vmap-fullslot-nonlinear.xml

Its not working with the videojs-ima, also its not working with https://googleads.github.io/googleads-ima-html5/vsi/ As I mentioned before: player will play the first AD, but if you will wait to finish this ad, or skip it, the next one won't be played, and the player hags up. There will be still controls from AD overlay etc. I'm aware that this bug applies to all IMA players on the market :(

Kiro705 commented 2 years ago

Hello @komw ,

Thank you for creating the completed xml link to test with. I was able to see the behavior with the player stalling after the first ad in both the videoJS sample and VSI player.

Since, as you pointed out, this happens for all IMA players, it may be a limitation of IMA. And I would recommend raising this issue on the IMA technical forum to surface this for all IMA users.

Looking at the types of ads, it may be an issue with the non-linear ad. IMA expects non-linear ads to display during content playback. See this sample non-linear ad. Based on that, this may be a misuse of non-linear ads.