Closed cristianpacu-ml closed 2 years ago
Hi @cristianpacu-ml ,
Thanks for catching this, it looks like it was not updated with the OMID access mode API change on 12/16/2021.
I will work on making this change in an upcoming release.
Jackson IMA SDK team
Code updated in https://github.com/googleads/videojs-ima/commit/bb3a8e0eb0f65f7c5d3958f514f36dffda54b4b3
Will go live in the upcoming NPM release.
it looks like the implementation of
omidMode
insrc/client-side/sdk-impl.js
might be inverted. Right now it is implemented like this:This means that when the dictionary is created, we assign the vendor to de access mode:
According to the documentation, the implementation should be the other way around:
I suggest the following change:
omidValues would also be a dictionary where the key is still the access mode and the value is an array of vendors to be assigned to that access mode. E.g: