search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

Property authKey of the streamRequest object should be authToken #1060

Closed ieyara closed 2 years ago

ieyara commented 2 years ago

videojs.ima.js script is making use of streamRequest.authKey property in https://github.com/googleads/videojs-ima/blob/main/dist/videojs.ima.js#L3060

According to StreamRequest class documentation (https://developers.google.com/interactive-media-ads/docs/sdks/html5/dai/reference/js/StreamRequest) the correct property name is authToken.

Kiro705 commented 2 years ago

Hello @ieyara ,

Thank you for catching this, I will look to implement this fix.

Jackson IMA SDK team

Kiro705 commented 2 years ago

This bug is addressed in this commit: https://github.com/googleads/videojs-ima/commit/a1cbb10bc43828dfee35a1d0f8696c631df230f9

It should go live in the next npm release.

Kiro705 commented 2 years ago

This fix is available in v2.1.0.