search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

Deprecated? #1065

Closed renebaudisch closed 1 year ago

renebaudisch commented 1 year ago

Is this code still up to date? https://github.com/googleads/videojs-ima/blob/main/src/client-side/controller.js#L116

The IMA docs do not say anything about deprecation: https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima.AdsRequest?hl=en

Kiro705 commented 1 year ago

Hello @renebaudisch ,

This videojs-IMA plugin will detect if the player is muted or set to autoplay, and update the ad request. See here.

The IMA parameters are not deprecated, as you pointed out.

Let me know if you have any follow-up questions.

renebaudisch commented 1 year ago

I didn't point that out, the plugin does. I just wondered why. And the detection happens if you don't set it manually, so...