search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

IMA plugin broken with video.js >= 7.21.1 #1077

Closed johngeorgewright closed 1 year ago

johngeorgewright commented 1 year ago

There was a change in video.js@7.21.1 which has negatively affected this plugin and now breaks during initialization.

During construction of the Controller, you'll notice the playerWrapper is created before the adUi property.

Screenshot 2023-02-02 at 14 05 48

With the latest video.js changes, there is no longer a timeout after the readyness of the player which now causes the playerWrapper to immediately invoke a volume change...

Screenshot 2023-02-02 at 14 06 21

Which invokes a volume change in the Controller...

Screenshot 2023-02-02 at 14 06 32

Which requires the adUi property, which is yet to be set.

Screenshot 2023-02-02 at 14 05 24
Kiro705 commented 1 year ago

Hello @johngeorgewright ,

Thank you for sharing this issue. I will plan to look into a fix for the next plugin update.

Thank you, Jackson IMA SDK team

Kiro705 commented 1 year ago

Quick update, @johngeorgewright ,

I was working on reproducing this issue, and was testing using video.js 7.21.2. However I was not able to see the error. Were there any other changes needed to see the error?