googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

AdsRenderingSettings: { useStyledNonLinearAds: true} not setting close button? #1087

Closed spormeon closed 1 year ago

spormeon commented 1 year ago

it seems that setting: AdsRenderingSettings: { useStyledNonLinearAds: true} is not setting a close button on the ad, the ad is a direct ad being delivered from GAM

Kiro705 commented 1 year ago

Hello @spormeon ,

This setting only applies to Non-Linear ads being served. It will not apply to other ad types.

You can test your implementation with this non-linear sample tag. If useStyledNonLinearAds: true, there should be an 'X' button on the ad that can close it.

Please let me know if you have any additional questions.

Thank you, Jackson IMA SDK team

spormeon commented 1 year ago

it is a non-linear ad that being delivered from gam

spormeon commented 1 year ago

used the tag you said, no close button?

Adysis_Video_Demo

Kiro705 commented 1 year ago

Hello @spormeon ,

Would you be able to share a sample that reproduces the issue?

When initiating IMA with the following settings, I am able to see the 'X' button.

const imaOptions = {
    adTagUrl: 'my-ad-tag',
    adsRenderingSettings: {
      useStyledNonLinearAds: true,
    },
};

  this.player.ima(imaOptions);

Make sure to use the correct case for adsRenderingSettings as seen in the Additional settings section.

Jackson IMA SDK team

spormeon commented 1 year ago

capital A by the looks of it then, as that whats in the ima documentation, should bring that inline for consistancy?

Kiro705 commented 1 year ago

Hello @spormeon ,

The capital AdsRenderingSettings is the IMA class name. The lower case adsRenderingSettings is the parameter used in this plugin's additional settings, and this is in line with how other settings parameters are set up.

Please feel free to reopen this issue if you have any additional concerns.

Jackson IMA SDK team