googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
445 stars 285 forks source link

On VMAP, adslog event only triggered if the whole pod is error #1146

Closed Decoydoll closed 1 month ago

Decoydoll commented 1 month ago

Given this vmap, which is a modified version of a google sample. As you can see, the preroll has 1 ad and the midroll has 3 ads. Then, I changed the slotname of the ad tag uri of the preroll-ad-1 and the midroll-1-ad-1 to make them return empty vast.

Then, I added an adslog event listener to print out the event like this:

player.on('adsready', function (){
  player.on('adslog', function (event){
    console.log("Got error")
    console.log(event)
  })
});

What I expected is 2 prints of Got error. But, what I got was only 1 print, and it was from the preroll. It was only after I made all of the midroll ads to return empty vast, I got 2 prints of Got error.

Is this something expected? Is it possible to trigger adslog on every ad error, not the whole pod error? Because of this, it is not possible to know which vast tag on which position does produce error.

Decoydoll commented 1 month ago

It seems it only happen for empty vast error. I tried with media error, the event is triggered on all position.