CI and test-stage edits inside origin: .travis.yml & package.json

googleads / videojs-ima

IMA SDK Plugin for Video.js

Apache License 2.0

450 stars 284 forks source link

CI and test-stage edits inside origin: .travis.yml & package.json #811

Closed Viktor286hearts closed 5 years ago

Viktor286hearts commented 5 years ago

Modifications for CI test adaptation

Kiro705 commented 5 years ago

Hi @Viktor286hearts,

Can you refactor this to instead of commenting out elements of files, deleting them.

Also, if you could add comments to the test files you are adding, and also explain the changes to the travis.yml in a comment.

This way we can get a better understanding of the changes you are implementing and how to best add that to the module.

Thanks, Jackson IMA SDK DevRel

Kiro705 commented 5 years ago

Hi @Viktor286hearts,

It looks like the focus of this PR was to have the travis test past. I worked on another PR to updated it so they are passing for firefox. Because of that, I will be closing this PR, but thanks for bringing this to our attention.