googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

Fix: Ad click through would trigger the AdsOnPaused method without pausing the ad playback #818

Closed arnaudcasame closed 5 years ago

arnaudcasame commented 5 years ago

Ad play/pause control changes when adContainer is clicked without really pausing the ad playback. This PR fixes the behavior by taking off the click event listener from AdDisplayContainer

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

arnaudcasame commented 5 years ago

@googlebot I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.