search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

Do not display plugin countdown on mobile #836

Closed Kiro705 closed 4 years ago

cdatehortuab commented 4 years ago

Hello, you introduced a bug with this PR. If you check line 149 in ad-ui.js there is an if clause:

if (!this.controller.getIsMobile) {

But this.controller.getIsMobile is a function so it always has a truthy value so that clause is never true and ima-countdown-div never gets the appropiate attributes and it is always hidden, not only for mobile.

@Kiro705 @gschoppe