search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

Fixes #855 #856

Closed cdatehortuab closed 4 years ago

cdatehortuab commented 4 years ago

Fixes #855

That bug was caused because a wrong logic on onAdBreakStart function on src/ad-ui.js file.

Previous logic says that "if the ad is a JS ad and the option showControlsForJSAds is falsy then plugin should hide the controls div and elsewhere show the controls div".

The correct logic (and that is the implemented solution) is that "if the ad is a JS ad and the option showControlsForJsAds is truthy then plugin should display the controls div and elsewhere hide the controls div.

Look at the result here with the same conditions in #855:

Fixed #855

Kiro705 commented 4 years ago

For the controlsDiv I believe the only instance for it to be show is if the ad is VPAID (contentType === 'application/javascript') and if showControlsForJSAds is true. This is the current state of the code.

Please see https://github.com/googleads/videojs-ima/issues/855 It looks that this was resolved as an error in implementation and not a bug in the plugin.