search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

what are the options on vpaidMode , no info in any docs #918

Closed spormeon closed 4 years ago

spormeon commented 4 years ago

what are the options on vpaidMode , no info in any docs

default=secure

vpaidMode: INSECURE don't work, throws error:

prebid-config.obv.js:5 Uncaught (in promise) ReferenceError: INSECURE is not defined

Kiro705 commented 4 years ago

Hello @spormeon ,

Here is the IMA documentation for vpaidMode and its options.

Please let me know if you have farther questions.

spormeon commented 4 years ago

INSECURE doesn't work as I put above: Its turned off in this screenshot but when on, it errors as above:

prebid-config_obv_js_—_Prebid_Publishers__Workspace_

Kiro705 commented 4 years ago

Please see this line from the IMA SDK HTML5 advanced example that highlights how to use setVpaidMode.

For your IMA implementation, the line would look like:

vpaidMode: google.ima.ImaSdkSettings.VpaidMode.INSECURE,

Please let me know if that helps resolve the issue.

spormeon commented 4 years ago

so like this?

prebid-config_obv_js_—_Prebid_Publishers__Workspace_

Kiro705 commented 4 years ago

Yes, that looks correct, except for one small change.

My original response set vpaidMode to ENABLED because I copied it from the advanced example. I have now edited my response to set it to INSECURE. Please also change it to INSECURE if that is how you wish to set vpaidMode.

spormeon commented 4 years ago

ye sure, i worked that out, thanks

dioramayuanito commented 4 years ago

i always use integer value for vpaidMode option. 0 for disable. 1 for enable secure iframe mode as a default. 2 for enable insecure iframe mode (not recommended but i can use it if some adnetwork vpaid fail to run some vpaid campaigns)

cmiiw

spormeon commented 4 years ago

@dioramayuanito do you keep switching it to different ones then?, or leave on 2 all the time. I'm seeing vpaid errors on tags/ suppliers, thats why i'm looking into this

Kiro705 commented 4 years ago

Hello @dioramayuanito ,

It is not recommended to use the value of the variable, but instead the variable itself (google.ima.ImaSdkSettings.VpaidMode.INSECURE in this case).

The reason being, the IMA engineering team expects its users to use the variable, and may change the associated value without updating the IMA release history. I wanted to bring this up, because I have seen this lead to critical issue for publishers in the past.

dioramayuanito commented 4 years ago

i have a "feeling", that running my player in vpaidMode:2 will make a vpaid campaign get a bigger chance to run properly, because insecure iframe mode run in a non-proxy-player mode. But i only switch vpaidMode:1 into vpaidMode:2 if our campaign manager told us that we have a problem in his/her campaign.

spormeon commented 4 years ago

ok , got it, i cant be doing that 99% is programmatic stuff, so i'd be sitting there all day switch between the things, that aint sustainable

dioramayuanito commented 4 years ago

ok, i will change it