search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

cant get disabledAdControls to work #921

Closed spormeon closed 4 years ago

spormeon commented 4 years ago

i updated to 1.8.0 and am trying to turn off controls in effect with: i'm presuming this is the right way to do it, juts add to the imaOptions as again, I can't see any info anywhere showing where to put etc

prebid-config_obv_copy_js_—_Prebid_Publishers__Workspace_-2

Kiro705 commented 4 years ago

disableAdControls was added in version 1.8.0, can you confirm that you are on this version or higher?

Here is the commit that added the feature (commit)

spormeon commented 4 years ago

yep as put above, updated to 1.8.0

Kiro705 commented 4 years ago

Can you verify that the ima-controls-div-showing class is not being added to your ad controls div?

I was able to see disableAdControls work on my test app

spormeon commented 4 years ago

this?

DevTools_-_127_0_0_1_5500_prebid_pub000017_index_outside_html

spormeon commented 4 years ago

just a thought, but is there a conflict with showControlsForJSAds: true, which I also have set, one cancelling the other out sort of idea?

Kiro705 commented 4 years ago

Hello @spormeon ,

The way disableAdControls works can be seen here in ad-ui.js. It will add the ima-controls-div-showing class only if disableAdControls is false.

For this to work it is important that there is a corresponding ima-controls-div-showing class in your css, like in videojs.ima.css.

showControlsForJSAds works by hiding the controls if the ad's content type is application/javascript, here in ad-ui.js. Note this will only happen for VPAID ads or javascript based ads.

I have verified these are working as intended, would it be possible for you to share steps to reproduce, or code snippets to help me reproduce the issue?

spormeon commented 4 years ago

the css item is there:

videojs_ima1_8_0_css_—_Prebid_Publishers__Workspace_

seems there is something else wrong then, as disableAdcControls is set to true, and there no div showing, but controls are still there when you float over the ad

what other code snippets do you need?

Kiro705 commented 4 years ago

In your previous comment showing the dom, I do not see the class ima-controls-div-showing being added. This is expected behavior. Please see the attached image of my player with ads playing and controls not showing. This is the same state when it is moused over.

If your issue persists, please share any relevant code or steps I would need to reproduce the issue, including ad-tags and specific browsers the error is visible on.

hidden_ad_controls
spormeon commented 4 years ago

test page here: https://ads.vsvl.co.uk/pub000017/index.outside.html

Kiro705 commented 4 years ago

Hello @spormeon ,

Looking at your test page, the file named videojs.ima.min1.8.0.js is actually version 1.7.5. If you search within the file, you will see var n="1.7.5" indicating the version number. I am not sure how this could have happened, but updating your videoJS-IMA to v1.8.0 should resolve the issue.

Please let me know if that resolves your issue.

spormeon commented 4 years ago

better check your zip file for 1.8.0. got a school boy error lol

spormeon commented 4 years ago

you def got something wrong, you now have 1.8.0 in the 1.8.1 download zip file

Kiro705 commented 4 years ago

Thanks for surfacing this issue. I had been testing through the npm version and not the zip file.

Latest zip files should now contain the latest version.

Can you confirm if disableAdControls is working for you?